◐ Shell
clean mode source ↗

Revert "gh-46376: Return existing pointer when possible in ctypes (#1… by vstinner · Pull Request #108688 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@vstinner

@vstinner vstinner commented

Aug 30, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

…07131)"

This reverts commit 08447b5.

Revert also _ctypes.c changes of the PyDict_ContainsString() change, commit 6726626.

…es (python#107131)"

This reverts commit 08447b5.

Revert also _ctypes.c changes of the PyDict_ContainsString() change,
commit 6726626.

@vstinner

Copy link Copy Markdown

Member Author

@ambv @code-of-kpp: Would you be ok to revert the change to fix #107940 regression for now, and reapply the change later once the regression is fine?

@vstinner

Copy link Copy Markdown

Member Author

Revert also _ctypes.c changes of the PyDict_ContainsString() change, commit 6726626.

This change is not in the 3.12 branch. This PR should be backported manuallly to the 3.12 branch with git revert 54aaaadef8a44324f6be674707c67a3516470ff6.

@vstinner

vstinner commented

Sep 4, 2023

Copy link Copy Markdown

Member Author

@ambv ambv merged commit 5a79d2a into python:main Sep 4, 2023

Thanks :-)

hugovk pushed a commit to hugovk/cpython that referenced this pull request

Sep 4, 2023
…es (#1… (python#108688)

This reverts commit 08447b5.

Revert also _ctypes.c changes of the PyDict_ContainsString() change,
commit 6726626.

@hugovk hugovk mentioned this pull request

Sep 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @ambv @bedevere-bot