gh-108765: Remove old prototypes from pyport.h by vstinner · Pull Request #108782 · python/cpython

bedevere-bot

Conversation

Move prototypes of gethostname(), _getpty() and struct termios from pyport.h to the C code using them: posixmodule.c, socketmodule.c and termios.c.

Replace "#ifdef SOLARIS" with "#ifdef __sun".

Issue: C API: Cleanup header files #108765

Move prototypes of gethostname(), _getpty() and struct termios from
pyport.h to the C code using them: posixmodule.c, socketmodule.c and
termios.c.

Replace "#ifdef SOLARIS" with "#ifdef __sun".

This was referenced

Sep 1, 2023

vstinner marked this pull request as ready for review

September 2, 2023 13:46

Buildbots are happy with this change: #108784

@kulikjak: It would be nice if you can double check the Solaris change:

Replace "#ifdef SOLARIS" with "#ifdef __sun".

I just realized that it's merged already - I rebased that older PR to remove it.
#23208

gh-108765: Remove old prototypes from pyport.h by vstinner · Pull Request #108782 · python/cpython

Conversation

Labels