gh-109408: Stop running patchcheck in CI by AA-Turner · Pull Request #109895 · python/cpython
AA-Turner
marked this pull request as ready for review
If I understand Éric's comments correctly, they don't block this PR itself, but more speak to improving the experience of running CPython's linting tools. In an effort to unblock this PR, I have opened #122333 as a sketch proposal.
A
I’m not active enough for my comments to have weight here. But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.
But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.
We did last year (https://discuss.python.org/t/34743), which I don't think raised any opposition to removing the (now duplicative) whitespace checks in CI. The wider patchcheck tool will remain, and #122333 will hopefully give us a unified 'local static checks' target. If/when that's merged, I think telling people on Discourse as a reminder would be useful.
A
hugovk
changed the title
GH-109408: Stop running patchcheck in CI
gh-109408: Stop running patchcheck in CI
It's been a week or so with no comment (and a year since the PR was opened), so I'll go ahead and merge this. If things go wrong we can always revert.
A
AA-Turner
deleted the
patchcheck/delete-azure-pipelines
branch