gh-109286 Updated macOS and Windows installers to SQLite 3.43.1 · Pull Request #110252 · python/cpython

Updated macOS and Windows installers to SQLite 3.43.1

I made changes to 4 files following the templated structure for this kind of update which was outlined in previous issues. The files that were changed are
Mac/BuildScript/build-installer.py
PCbuild/get_externals.bat
PCbuild/python.props
PCbuild/readme.txt

The issue is gh-109286

All commit authors signed the Contributor License Agreement.

Seems to be having an issue with the checksum variable. I copied that hash code directly from the site : https://sqlite.org/download.html. It is the correct hash assigned to the .tar.gz file for the source code download for version 3.43.1.

Please split it into two PRs, one for Windows and one for macOS installer.

Doing both in one PR is fine.

There are several failing checks right now, though:

• CLA Signing — Please sign our Contributor License Agreement.
  Required
  Details
  • This is the most important one; we cannot accept your contribution without a signed license agreement. You may need to configure user.email correctly in your local .gitconfig file and recreate your commits with the correct user information.
• bedevere/issue-number — No issue # in title or "skip issue" label found
  Required
  Details
  • This one just needs a rearrangement of the PR title, it should be of the form gh-###: <short description>
• Lint / lint (pull_request) Failing after 36s
  Details
  • You can run either make patchcheck or pre-commit locally, or just copy and apply the patch provided in the output at the Details link.

Please split it into two PRs, one for Windows and one for macOS installer.

Doing both in one PR is fine.

I've been asked to do it separately in the past 🤷

Splitting is also fine :). It's largely a matter of personal taste; I'll be happy to merge a unified PR when it's clean and ready, but another core dev may well prefer a split.

We typically have two separate NEWS entries for these changes, as they affect the release more than build. You can add two entries in the same PR (just change the random characters near the end of the filename), but people are probably going to be more comfortable with one NEWS entry per PR, just because they won't have seen multiple ones so often.

I usually split these PRs, since the response time of the Windows and macOS teams can vary greatly :)

Please split it into two PRs, one for Windows and one for macOS installer.

Doing both in one PR is fine.

There are several failing checks right now, though:

• CLA Signing — Please sign our Contributor License Agreement.
  Required
  Details

  • This is the most important one; we cannot accept your contribution without a signed license agreement. You may need to configure user.email correctly in your local .gitconfig file and recreate your commits with the correct user information.

• bedevere/issue-number — No issue # in title or "skip issue" label found
  Required
  Details

  • This one just needs a rearrangement of the PR title, it should be of the form gh-###: <short description>

• Lint / lint (pull_request) Failing after 36s
  Details

  • You can run either make patchcheck or pre-commit locally, or just copy and apply the patch provided in the output at the Details link.

I just updated my .gitconfig file to use my GitHub email so that I should be able to sign the CLA now, but this PR is still associated with some other default email. Is the best way forward to create a new pull request with the updated associated email or is there some way to salvage this request?

Depends on the level of Git wizardry that you're comfortable with :). You can recreate the commits and force-push, or you can take the opportunity to split it up and push fresh commits to two new branches and thus new PRs.