◐ Shell
clean mode source ↗

GH-104584: Fix refleak when tracing through calls by brandtbucher · Pull Request #110593 · python/cpython

Conversation

@brandtbucher

This modifies _PyFunction_LookupByVersion to return a borrowed reference, which is what the caller assumes (and most internal "lookup" functions do, in general).

@brandtbucher brandtbucher changed the title GH-104854: Fix refleak when tracing through calls GH-104584: Fix refleak when tracing through calls

Oct 10, 2023

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I love how this already violates a likely future C API requirement. Glad that those requirements don't apply to internal APIs. :-)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

Labels

2 participants

@brandtbucher @gvanrossum