◐ Shell
clean mode source ↗

gh-106344 return ciphers in `SSLSocket.shared_ciphers()` after session reuse by kevinAlbs · Pull Request #110902 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@kevinAlbs

@kevinAlbs kevinAlbs commented

Oct 15, 2023

edited

Loading

Copy link Copy Markdown

Store client sent ciphers from the hello message. Revise SSLSocket.shared_ciphers() to return the intersection of client and server ciphers. This results in SSLSocket.shared_ciphers() returning ciphers after an SSL session is reused.

This is an alternative resolve: #106344

@bedevere-app

bedevere-app Bot commented

Oct 15, 2023

Copy link Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@github-actions

Copy link Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale

Stale PR or inactive for long period of time.

label

Apr 14, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner

@picnixz picnixz Awaiting requested review from picnixz picnixz will be requested when the pull request is marked ready for review picnixz is a code owner

Assignees

No one assigned

Labels

stale

Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SSLSocket.shared_ciphers() does not document None is returned on session reuse

1 participant

@kevinAlbs