Enable most pyflakes rules when running ruff on `Lib/test` in CI by AlexWaygood · Pull Request #110917 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Conversation
Ruff's pyflakes rules generally have very few false-positive errors; I think we generally should aim to have as many enabled in CI as is practical. With the exception of a few rules that currently have many hits when enabled on our test suite, this PR enables the full suite of pyflakes rules when running ruff on Lib/test/.
| b'\x01\xff': -255, | ||
| b'\x00\xff': -256, | ||
| b'\xff\x00': 255, | ||
| b'\x00\x01': 256, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a micro-bug flagged by ruff: this dictionary currently has two identical key/value pairs!
Adding DO-NOT-MERGE for now. This PR probably warrants discussion on Discourse before merging, since it's possible this could disrupt other core devs' workflows if they're unfamiliar with ruff
This PR is stale because it has been open for 30 days with no activity.
Labels
2 participants
