◐ Shell
clean mode source ↗

[3.6] bpo-34279: regrtest consider that skipped tests are ran (GH-11132) by miss-islington · Pull Request #11156 · python/cpython

the-knights-who-say-ni

Conversation

bpo-34279, bpo-35412: support.run_unittest() no longer raises
TestDidNotRun if a test result contains skipped tests. The
exception is now only raised if no test have been run and no test
have been skipped.
(cherry picked from commit 3a8f4fe)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

@vstinner

@ned-deily

@vstinner

@ned-deily it's hard for me to accept that I have to "abandon" (bugfixes in) 3.6 :-( I love this version! It's the version used for Python 3 in RHEL 8 beta!

@ned-deily

Yeah, 3.6 has been a big success, thanks to everyone’s hard work including yours. But it’s been in bug fix mode longer than any other 3.x release. Now we can focus on 3.7 bugs.

Labels