◐ Shell
clean mode source ↗

gh-108901: Deprecate `inspect.getcallargs` and slate it for removal by sobolevn · Pull Request #112236 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented

Nov 18, 2023

edited by github-actions Bot

Loading

AlexWaygood

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

terryjreedy

terryjreedy

terryjreedy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the details of code deprecation, but I improved the wording of the public announcements.

@sobolevn

@terryjreedy

The added code looks sensible but I would want someone more knowledgeable to check and a manual test of the notice.
EDIT: remove mistaken comment, and hide sobolevn's correct response thereto.

@sobolevn

This comment was marked as outdated.

itamaro

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phrasing nits in the news and whatnew entries

Co-authored-by: Itamar Oren <itamarost@gmail.com>

AlexWaygood

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexWaygood

@Wulian233

I also recently found this issue, which may have been forgotten here, and needs to be removed in the 3.16 if added in 3.14

@vstinner

@sobolevn

I guess that I will have to start everything over in 3.15 :)

@github-actions

This PR is stale because it has been open for 30 days with no activity.

@hugovk

I guess that I will have to start everything over in 3.15 :)

You have 3 weeks, or start over in 3.16 :)

Labels