◐ Shell
clean mode source ↗

gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows by serhiy-storchaka · Pull Request #113049 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

Dec 13, 2023

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

@serhiy-storchaka serhiy-storchaka force-pushed the win-chmod-follow-symlinks branch from 15c667b to 0d117a1 Compare

December 13, 2023 11:50

@AlexWaygood AlexWaygood removed their request for review

December 13, 2023 16:51

@erlend-aasland erlend-aasland left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two PEP-7 nits and two cases where we should be explicitly ignoring the return value (-Wunused-result).

Comment thread

Modules/posixmodule.c Outdated

Comment thread

Modules/posixmodule.c Outdated

Comment thread

Modules/posixmodule.c Outdated

Comment thread

Modules/posixmodule.c

@serhiy-storchaka serhiy-storchaka merged commit 29f7eb4 into python:main

Dec 14, 2023

@serhiy-storchaka serhiy-storchaka deleted the win-chmod-follow-symlinks branch

December 14, 2023 11:28

corona10 pushed a commit to corona10/cpython that referenced this pull request

Dec 15, 2023

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

Assignees

No one assigned

Labels

OS-windows type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @erlend-aasland