gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows by serhiy-storchaka · Pull Request #113049 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
merged 14 commits into
Merged
Conversation
Member
bedevere-app
Bot
mentioned this pull request
serhiy-storchaka
force-pushed
the
win-chmod-follow-symlinks
branch
from
15c667b to
0d117a1
Compare
serhiy-storchaka added 4 commits
serhiy-storchaka
marked this pull request as ready for review
serhiy-storchaka
requested review from
AlexWaygood and
erlend-aasland
as code owners
bedevere-app
Bot
added
the
awaiting core review
label
serhiy-storchaka added 3 commits
AlexWaygood
removed their request for review
serhiy-storchaka added 2 commits
erlend-aasland
left a comment
erlend-aasland
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two PEP-7 nits and two cases where we should be explicitly ignoring the return value (-Wunused-result).
Modules/posixmodule.c Outdated
Modules/posixmodule.c Outdated
Modules/posixmodule.c Outdated
serhiy-storchaka and others added 4 commits
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
serhiy-storchaka
merged commit
29f7eb4
into
python:main
bedevere-app
Bot
removed
the
awaiting core review
label
serhiy-storchaka
deleted the
win-chmod-follow-symlinks
branch
corona10 pushed a commit to corona10/cpython that referenced this pull request
aisk pushed a commit to aisk/cpython that referenced this pull request
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment