gh-113119: Fix the macOS framework installer build by gpshead · Pull Request #113268 · python/cpython
gh-113117: Fix the macOS framework installer build
gh-113119: Fix the macOS framework installer build
Related: since this didn't come up in testing for the original change, it sounds like we're missing --enable-framework in either CI or buildbots?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick fix.
I manually tested that building works on a mac with a configure --enable-framework - FWIW there appear to be a pile of tests that do not pass in framework builds regardless of this (looks environment related when launching python as a child process).
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
aisk pushed a commit to aisk/cpython that referenced this pull request
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.