bpo-20182: AC convert Python/sysmodule.c by taleinat · Pull Request #11328 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Merged
Conversation
Contributor
taleinat added 2 commits
Python/sysmodule.c Outdated
Python/sysmodule.c Outdated
Python/sysmodule.c Outdated
Python/sysmodule.c Outdated
Python/sysmodule.c Outdated
Python/sysmodule.c Outdated
taleinat
commented
Dec 28, 2018
taleinat commented
Contributor Author
Thanks for the quick and thorough review @serhiy-storchaka!
I've resolved all of the issues you brought up, and would be happy if you took another look.
serhiy-storchaka
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @taleinat. There is still an issue with the too long line. The rest LGTM.
taleinat
commented
Dec 30, 2018
taleinat commented
Contributor Author
@serhiy-storchaka, I've re-formatted all of the AC doc-strings in the files to have a maximum width of 72 characters.
Python/sysmodule.c Outdated
Python/sysmodule.c Outdated
Python/sysmodule.c Outdated
taleinat
commented
Dec 30, 2018
taleinat commented
Contributor Author
@serhiy-storchaka, good catches! I've resolved the final issues.
serhiy-storchaka
approved these changes
ede0b6f
into
python:master
This was referenced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
