gh-103323: Remove current_fast_get() unused parameter by vstinner · Pull Request #114593 · python/cpython
The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.
@ericsnowcurrently @colesbury @corona10: Would you mind to review this change?
The change commit f8abfa3 modified current_fast_get(). Before the Python Thread State was retrieved from runtime, but it's no longer the case.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IIRC, the main reason I left the parameter was to reduce churn. After that I didn't see any harm in leaving the parameter. That said, I'm not opposed to dropping it.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more straightforward to me too
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merged, thanks for reviews.
aisk pushed a commit to aisk/cpython that referenced this pull request
…14593) The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.