◐ Shell
clean mode source ↗

gh-76763: Make chr() always raising ValueError for out-of-range values by serhiy-storchaka · Pull Request #114882 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

Feb 1, 2024

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

Previously it raised OverflowError for very large or very small values.

… values

Previously it raised OverflowError for very large or very small values.

@ericsnowcurrently ericsnowcurrently removed their request for review

February 2, 2024 00:26
…e-76763.o_2J6i.rst

Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>

@serhiy-storchaka

Copy link Copy Markdown

Member Author

@vstinner, it has the same effect to your #5218, but without raising and catching an OverflowError.

@mdickinson mdickinson left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit e2c4038 into python:main

Feb 10, 2024

@serhiy-storchaka serhiy-storchaka deleted the chr-overflow branch

February 10, 2024 10:21

fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request

Feb 14, 2024
… values (pythonGH-114882)

Previously it raised OverflowError for very large or very small values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpt eendebakpt eendebakpt left review comments

@vstinner vstinner Awaiting requested review from vstinner

+1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @mdickinson @eendebakpt