◐ Shell
clean mode source ↗

gh-101100: Fix `load_module` ref by smontanaro · Pull Request #114982 · python/cpython

@smontanaro

@smontanaro smontanaro commented

Feb 4, 2024

edited by github-actions Bot

Loading

Text describes a user-provided method, perhaps only described in detail in `PEP 302`.

@AlexWaygood

serhiy-storchaka

@smontanaro

The discussion around load_module seems familiar (@AlexWaygood?). I added a reference to the method.

@AlexWaygood

The discussion around load_module seems familiar (@AlexWaygood?). I added a reference to the method.

Yes, we already had this conversation in #114729 (comment). And I still think the best way to correct this reference warning is to update the glossary entry so that it no longer refers to a deprecated method at all.

If that requires an importlib expert, then we should wait for an importlib expert to take a look.

@smontanaro

I will let @AlexWaygood and @serhiy-storchaka sort this out. Let me know your collective decision and I'll change the ref to suit so we can close out this PR.

@serhiy-storchaka

I agree that it is better to not refer to the deprecated method. But this requires the larger change that simply adding the exclamation mark.

So this Sphinx warnings serves as a reminder to rewrite the docs.

@AlexWaygood

I agree that it is better to not refer to the deprecated method. But this requires the larger change that simply adding the exclamation mark.

So this Sphinx warnings serves as a reminder to rewrite the docs.

Exactly. I would prefer that we leave this Sphinx warning unfixed for now, until we are able to fix it properly, by updating the entry so that it no longer refers to a deprecated method. I said this in #114729 (comment) and #114982 (comment)

@smontanaro

Closing. Will let others decide how best to correct this.