bpo-35582: Inline arguments tuple unpacking in handwritten code. by serhiy-storchaka · Pull Request #11524 · python/cpython
Conversation
Member
Inline PyArg_UnpackTuple() and _PyArg_UnpackStack() in performance
critical code in the builtins and operator modules.
Inline PyArg_UnpackTuple() and _PyArg_UnpackStack() in performance critical code in the builtins and operator modules.
serhiy-storchaka
commented
Jan 11, 2019
serhiy-storchaka commented
Member Author
This PR rewrites again some of code changed in #11435. It looks now simpler but has the same performance.
vstinner
reviewed
Python/bltinmodule.c Outdated
Python/bltinmodule.c Outdated
vstinner
approved these changes
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please keep "w" variable in builtin_iter() as I proposed in a comment.
7934266
into
python:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
