◐ Shell
clean mode source ↗

gh-103092: Adapt _lsprof methods to Argument Clinic by aisk · Pull Request #115242 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Closed

aisk

wants to merge 8 commits into

Conversation

@aisk

@aisk aisk commented

Feb 10, 2024

edited by bedevere-app Bot

Loading

@erlend-aasland

A couple of remarks after a quick glance1:

  • It seems there are many similar signatures; consider using the AC "clone" feature
  • The defining class converter should be marked as positional-only (/)
  • Style nit: can you use a more concise clinic input block:
    • drop the extra newline between /*[clinic input] and the function def
    • drop the extra newline between the function def and the parameter section

Footnotes

  1. I'll be able to do a review tomorrow or Monday

@aisk aisk mentioned this pull request

Feb 11, 2024

@erlend-aasland

@aisk aisk deleted the lsprof-clinic branch

March 1, 2024 05:24

Labels

2 participants

@aisk @erlend-aasland