gh-103092: Adapt _lsprof methods to Argument Clinic by aisk · Pull Request #115242 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Closed
wants to merge 8 commits into
Conversation
A couple of remarks after a quick glance1:
- It seems there are many similar signatures; consider using the AC "clone" feature
- The defining class converter should be marked as positional-only (
/) - Style nit: can you use a more concise clinic input block:
- drop the extra newline between
/*[clinic input]and the function def - drop the extra newline between the function def and the parameter section
- drop the extra newline between
Footnotes
-
I'll be able to do a review tomorrow or Monday ↩
aisk
mentioned this pull request
aisk
deleted the
lsprof-clinic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters