gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable by erlend-aasland · Pull Request #115449 · python/cpython

erlend-aasland

This comment was marked as outdated.

I think I prefer this fix.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in #115448 (comment). This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test. But either is probably fine; no strong preference :)

This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test.

You could maybe add a comment noting that the imports need to be in precisely that order

You could maybe add a comment noting that the imports need to be in precisely that order

Yes, that seems fair to the future reader.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Thanks for the review(s), Alex!

🤖 New build scheduled with the buildbot fleet by @encukou for commit d9a099c 🤖

The command will test the builders whose names match following regular expression: AMD64 RHEL7

The builders matched are:

AMD64 RHEL7 LTO PR
AMD64 RHEL7 PR
AMD64 RHEL7 Refleaks PR
AMD64 RHEL7 LTO + PGO PR

fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request

Feb 14, 2024

…hon#115449)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>