◐ Shell
clean mode source ↗

[3.9] gh-97032: avoid test_squeezer crash on macOS buildbots (GH-115508) by miss-islington · Pull Request #115655 · python/cpython

PR buildbot failures are unrelated.

@ambv, IMO this is the best way to fix the 3.9 buildbot failures. There's a more robust fix in later branches.
The other approaches considered are:

  • change library detection logic, which isn't ideal in source-only security releases
  • configuring the buildbot to use Homebrew tkinter -- too much work for a library that isn't really tested anyway

See Pablo's comment for 3.10:

While I understand the fix and the rationale, I have to say that I still find it a bit "hacky" (for the lack of a better term). Given that this is to fix CI in old branches I am fine merging it as it has no user impact, but ideally we should fix this in the build system in main if we detect that we are using an incompatible tkinter .

I any case, I am merging this as I think the proper fix will be more aggressive and we need to have the CI green to avoid hiding other problems. Thanks @encukou and @ned-deily for the PR and the explanation.

In main, the build system prefers pkg-config, and shouldn't pick up Apple's abandoned tk.