◐ Shell
clean mode source ↗

[3.7] bpo-35283: Add deprecation warning for Thread.isAlive (GH-11454) by corona10 · Pull Request #11604 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@corona10

@corona10 corona10 commented

Jan 18, 2019

•

edited

Loading

Copy link Copy Markdown

Member

Add a pending deprecated warning for the threading.Thread.isAlive() method..
(cherry picked from commit 89669ff)

Co-authored-by: Dong-hee Na donghee.na92@gmail.com

https://bugs.python.org/issue35283

 
…-11454)

Add a deprecated warning for the threading.Thread.isAlive() method..
(cherry picked from commit 89669ff)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include the fix https://github.com/python/cpython/pull/11596/files into this PR?

@corona10

Copy link Copy Markdown

Member Author

No issue yet all

@corona10

Copy link Copy Markdown

Member Author

@vstinner Done!

@vstinner vstinner merged commit c2647f2 into python:3.7

Jan 18, 2019

@vstinner

Copy link Copy Markdown

Member

Bye bye isAlive()! I merged your PR @corona10, thanks.
corona10 reacted with thumbs up emoji

@corona10 corona10 deleted the backport-89669ff-3.7 branch

August 9, 2019 15:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot