◐ Shell
clean mode source ↗

gh-113538: Revert "gh-113538: Add asycio.Server.{close,abort}_clients (#114432)" by gvanrossum · Pull Request #116632 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented

Mar 11, 2024

edited by github-actions Bot

Loading

Copy link Copy Markdown

Member

Alas, we need to revert because the test doesn't always seem to pass.

@CendioOssman I hope you don't mind. We have a commitment to keep main free of test failures, and I don't know how to fix the test. :-(


📚 Documentation preview 📚: https://cpython-previews--116632.org.readthedocs.build/

@gvanrossum

Copy link Copy Markdown

Member Author

I've set this to auto-merge since I may not be around later today.

@gvanrossum gvanrossum merged commit ba13215 into python:main

Mar 12, 2024

@gvanrossum gvanrossum deleted the revert-114432 branch

March 12, 2024 02:23

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 25, 2024
…ort}_clients (python#114432)" (python#116632)

Revert "pythongh-113538: Add asycio.Server.{close,abort}_clients (python#114432)"

Reason: The new test doesn't always pass:
python#116423 (comment)

This reverts commit 1d0d49a.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request

Apr 17, 2024
…ort}_clients (python#114432)" (python#116632)

Revert "pythongh-113538: Add asycio.Server.{close,abort}_clients (python#114432)"

Reason: The new test doesn't always pass:
python#116423 (comment)

This reverts commit 1d0d49a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gvanrossum