gh-117122: Fix pystats after incremental GC changes by mdboom · Pull Request #117123 · python/cpython
| increment_size += expand_region_transitively_reachable(&increment, gc, gcstate); | ||
| } | ||
| GC_STAT_ADD(1, objects_queued, region_size); | ||
| GC_STAT_ADD(1, objects_queued, increment_size); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is correct, but region_size doesn't exist.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to conflict with #117120.
Once that's in, I'll review this properly.
| increment_size += expand_region_transitively_reachable(&increment, gc, gcstate); | ||
| } | ||
| GC_STAT_ADD(1, objects_queued, region_size); | ||
| GC_STAT_ADD(1, objects_queued, increment_size); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?
Actually, don't worry about the merge conflict. I can fix it in my PR
I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?
I leave that to you, but this stat is new as of #116206 (it's just that it never compiled).