◐ Shell
clean mode source ↗

[WIP] bpo-35537: Fix function name in os.posix_spawnp() errors by vstinner · Pull Request #11719 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

python:masterfrom

vstinner:spawnp_func_name

Feb 1, 2019

Merged

[WIP] bpo-35537: Fix function name in os.posix_spawnp() errors#11719

vstinner

merged 1 commit into

python:masterfrom

vstinner:spawnp_func_name

Conversation

@vstinner

@vstinner vstinner commented

Feb 1, 2019

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@vstinner

vstinner commented

Feb 1, 2019

Copy link Copy Markdown

Member Author

I marked the PR as WIP because I noticed that test_posix fails even without my PR: see PR #11718.

@vstinner

vstinner commented

Feb 1, 2019

Copy link Copy Markdown

Member Author

I merged PR #11718. I rebased this PR on top of it.

@izbyshev, @nanjekyejoannah: Would you mind to check that the function name is properly passed to all os.posix_spawn() and os.posix_spawnp() error messages in my PR?

@pablogsal

Copy link Copy Markdown

Member

@vstinner I opened https://bugs.python.org/issue35876 after seeing the buildbot failures to track the failing test fixes.

@nanjekyejoannah

Copy link Copy Markdown

Contributor

@vstinner the function name passing lgtm. I haven't identified anything contrary.

@vstinner vstinner merged commit 325e4ba into python:master

Feb 1, 2019

@vstinner vstinner deleted the spawnp_func_name branch

February 1, 2019 14:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@izbyshev izbyshev izbyshev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @pablogsal @nanjekyejoannah @izbyshev @the-knights-who-say-ni @bedevere-bot