gh-117891: handle undefined TARGET_OS_OSX by jmroot · Pull Request #117892 · python/cpython
Conversation
This macro is not defined by older macOS SDKs, and the code previously didn't distinguish between it being undefined and being defined to 0.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functionally looks fine; however, as I mentioned on my review of #117887, there's another 2 related uses of TARGET_OS symbols that need to be cleaned up; I'm not sure it's better to tackle all of them in one PR, rather than multiple PRs fixing one each.
Thanks again for the issue and PR. The suggested change has been rolled up and merged in PR #118073.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters