◐ Shell
clean mode source ↗

gh-94673: Fix compiler warning in typeobject.c by erlend-aasland · Pull Request #117980 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented

Apr 17, 2024

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Contributor

static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.

static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.

@ericsnowcurrently ericsnowcurrently left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I have one suggestion for handling it a different way, which preserves the intention of the original code.

erlend-aasland reacted with heart emoji
Comment thread

Objects/typeobject.c

@erlend-aasland erlend-aasland enabled auto-merge (squash)

April 17, 2024 17:28

@erlend-aasland erlend-aasland merged commit 353ea0b into python:main

Apr 17, 2024

@erlend-aasland erlend-aasland deleted the fix-warning branch

April 17, 2024 17:57

@ericsnowcurrently

Copy link Copy Markdown

Member

Thanks!

erlend-aasland reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

+1 more reviewer

@kalebers kalebers kalebers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland @ericsnowcurrently @kalebers