gh-94673: Fix compiler warning in typeobject.c by erlend-aasland · Pull Request #117980 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Contributor
static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.
static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.
erlend-aasland
added
the
skip news
label
erlend-aasland
requested a review
from markshannon
as a code owner
erlend-aasland
requested a review
from ericsnowcurrently
bedevere-app
Bot
added
the
awaiting core review
label
bedevere-app
Bot
mentioned this pull request
kalebers
approved these changes
ericsnowcurrently
approved these changes
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I have one suggestion for handling it a different way, which preserves the intention of the original code.
bedevere-app
Bot
added
awaiting merge
and removed
awaiting core review
labels
erlend-aasland
enabled auto-merge (squash)
erlend-aasland
merged commit
353ea0b
into
python:main
erlend-aasland
deleted the
fix-warning
branch
bedevere-app
Bot
removed
the
awaiting merge
label
ericsnowcurrently
commented
Apr 17, 2024
ericsnowcurrently commented
Member
Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment