◐ Shell
clean mode source ↗

gh-112730: use keyword only argument for colorize by methane · Pull Request #118086 · python/cpython

methane

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

@methane methane commented

Apr 19, 2024

•

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

@methane

methane commented

Apr 19, 2024

Copy link Copy Markdown

Member Author

sorry if there is a reason to use kwargs.

@methane

methane commented

Apr 19, 2024

Copy link Copy Markdown

Member Author

Maybe, you don't want to expose this option as public API.

@methane methane closed this

Apr 19, 2024

@maxeonyx

Copy link Copy Markdown

@methane I think this was a good PR? Although changing away from **kwargs back to just a named arg means that this change would break anyone providing invalid args.

And yeah possibly they didn't want to expose it? But why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@methane @maxeonyx