◐ Shell
clean mode source ↗

gh-117225: Move colorize functionality to own internal module by hugovk · Pull Request #118283 · python/cpython

hugovk

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@hugovk

@hugovk hugovk commented

Apr 25, 2024

•

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

Here's the refactoring postponed from PR #117583.

@nineteendo nineteendo left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these newlines.
Comment thread

Lib/traceback.py

@hugovk hugovk marked this pull request as ready for review

April 29, 2024 21:37

@hugovk

hugovk commented

Apr 29, 2024

Copy link Copy Markdown

Member Author

Somehow managed to find two free-threaded bugs with this PR, but they're fixed now.

@hugovk hugovk merged commit 3b3f8de into python:main

May 1, 2024

@hugovk hugovk deleted the doctest-refactor-colorize branch

May 1, 2024 18:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

2 more reviewers

@Privat33r-dev Privat33r-dev Privat33r-dev left review comments

@nineteendo nineteendo nineteendo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @Privat33r-dev @nineteendo