◐ Shell
clean mode source ↗

gh-117398: Move types to datetime state by vstinner · Pull Request #118606 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@vstinner

@vstinner vstinner commented

May 5, 2024

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

Move types to the datetime_state structure of the _datetime extension.

@vstinner

vstinner commented

May 7, 2024

Copy link Copy Markdown

Member Author

cc @erlend-aasland @neonene

I marked the PR as a draft until the main branch becomes Python 3.14.

erlend-aasland reacted with thumbs up emoji

@vstinner vstinner marked this pull request as ready for review

May 8, 2024 16:40

@vstinner vstinner requested review from abalkin and pganssle as code owners

May 8, 2024 16:40

@vstinner

vstinner commented

May 8, 2024

Copy link Copy Markdown

Member Author

The main branch is now Python 3.14. I mark the PR as ready for review.

@erlend-aasland @corona10: Do you want to review it?

Move types to the datetime_state structure of the _datetime
extension.

@erlend-aasland erlend-aasland left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as a first step!

@vstinner vstinner merged commit a895756 into python:main

May 10, 2024

@vstinner vstinner deleted the datetime_state branch

May 10, 2024 13:24

ericsnowcurrently pushed a commit to ericsnowcurrently/cpython that referenced this pull request

May 28, 2024
Move types to the datetime_state structure of the _datetime
extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @erlend-aasland