Revert "gh-115432: Add critical section variant that handles a NULL object (#115433)" by colesbury · Pull Request #118861 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Contributor
This reverts commit ad4f909.
This internal API ended up not being used.
…NULL object (python#115433)" This reverts commit ad4f909. The API ended up not being used.
colesbury
commented
May 9, 2024
colesbury commented
Contributor Author
@Yhg1s - this isn't really a bug fix, but it's definitely not a feature. Would it be appropriate to backport this revert to 3.13?
9f8175b to
49a359e
Compare
DinoV
approved these changes
DinoV
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Yhg1s
commented
May 9, 2024
Yhg1s commented
Member
Yeah, backporting it to 3.13 is fine until we get to rc1.
46c8081
into
python:main
miss-islington-app
Bot
commented
May 9, 2024
miss-islington-app Bot commented
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
…NULL object (pythonGH-115433)" (pythonGH-118861) This reverts commit ad4f909. The API ended up not being used. (cherry picked from commit 46c8081) Co-authored-by: Sam Gross <colesbury@gmail.com>
bedevere-app
Bot
commented
May 9, 2024
bedevere-app Bot commented
GH-118872 is a backport of this pull request to the 3.13 branch.
SonicField pushed a commit to SonicField/cpython that referenced this pull request
…NULL object (python#115433)" (python#118861) This reverts commit ad4f909. The API ended up not being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
