◐ Shell
clean mode source ↗

gh-119469: Fix _pyrepl reference leaks by ambv · Pull Request #119470 · python/cpython

Conversation

@ambv

@ambv ambv commented

May 23, 2024

edited by bedevere-app Bot

Loading

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that this change fix the issue:

$ ./python -m test test_pyrepl -u all -R 3:3 
(...)
Result: SUCCESS

lysnikolaou

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miss-islington-app

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 23, 2024
(cherry picked from commit 6e012ce)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>

@bedevere-app

@ambv ambv deleted the pyrepl-leak branch

May 23, 2024 17:28

ambv added a commit that referenced this pull request

May 23, 2024
(cherry picked from commit 6e012ce)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024

Labels