gh-121272: move __future__ import validation from compiler to symtable by iritkatriel · Pull Request #121273 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this could be a good performance improvement when using a ton of c extensions with python scripts that use import from statements on them.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
I agree, this could be a good performance improvement when using a ton of c extensions with python scripts that use import from statements on them.
This shouldn't impact performance.
This is about simplifying code in compile.c (in this case, making compiler_from_import no longer access the internals of struct compiler). This is part of a longer term plan to break up the compiler.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This is thoroughly tested in test_future_stmt/test_future.py and I confirmed that the code in future.c that sets ff_location makes sense.
