gh-121272: compiler no longer modifies the symtable, ste_coroutine always set during symtable construction by iritkatriel · Pull Request #121297 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
iritkatriel
commented
| compiler_exit_scope(c); | ||
| if (is_top_level_await && is_async_generator){ | ||
| c->u->u_ste->ste_coroutine = 1; | ||
| assert(c->u->u_ste->ste_coroutine == 1); |
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this assignment has been obsolete for a while now, see #6766 (comment).
JelleZijlstra
approved these changes
JelleZijlstra
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this is a job for the symtable, not the compiler. This looks to be well tested in test_compile_top_level_await in test_builtin.py.
9315688
into
python:main
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request
…on#121297) compiler no longer modifies the symtable after this.
estyxx pushed a commit to estyxx/cpython that referenced this pull request
…on#121297) compiler no longer modifies the symtable after this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
