◐ Shell
clean mode source ↗

GH-118926: Better distinguish between pointer and arrays in interpreter generator by markshannon · Pull Request #121496 · python/cpython

bedevere-app

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@markshannon

@markshannon markshannon commented

Jul 8, 2024

•

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

This is a supporting PR for #121318.

The code generator treats stack items of type PyStackRef * the same as arrays, which is incorrect.
This PR fixes that.

@markshannon markshannon merged commit bf8686e into python:main

Jul 9, 2024

@markshannon markshannon deleted the code-gen-arrays-vs-pointers branch

July 9, 2024 10:41

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request

Jul 11, 2024

@markshannon markshannon restored the code-gen-arrays-vs-pointers branch

July 16, 2024 13:44

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024

@markshannon markshannon deleted the code-gen-arrays-vs-pointers branch

August 6, 2024 10:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markshannon @Fidget-Spinner