[3.13] gh-117398: Use the correct module loader for iOS in datetime CAPI test (GH-120477) by neonene · Pull Request #121561 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
Contributor
#119604 added a CAPI test for subinterpreters in the datetime tests; however, the test uses the ExtensionFileLoader to load _testcapi. iOS requires the use of the AppleFrameworkLoader.
neonene
requested review from
abalkin and
pganssle
as code owners
bedevere-app
Bot
mentioned this pull request
bedevere-app
Bot
added
the
skip news
label
bedevere-app
Bot
mentioned this pull request
bedevere-app
Bot
added
the
awaiting review
label
This comment was marked as off-topic.
This comment was marked as off-topic.
bedevere-bot
commented
Jul 10, 2024
bedevere-bot commented
You don't have write permissions to trigger a build
neonene
commented
Jul 10, 2024
neonene commented
Contributor Author
@freakboy3742 Could you review the backport? I failed to trigger the iOS build bot.
neonene
mentioned this pull request
freakboy3742
commented
Jul 10, 2024
freakboy3742 commented
Contributor
!buildbot iOS
bedevere-bot
commented
Jul 10, 2024
bedevere-bot commented
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 987dd52 🤖
The command will test the builders whose names match following regular expression: iOS
The builders matched are:
iOS ARM64 Simulator PR
freakboy3742
approved these changes
bedevere-app
Bot
added
awaiting merge
and removed
awaiting review
labels
freakboy3742
merged commit
c08a302
into
python:3.13
bedevere-app
Bot
removed
the
awaiting merge
label
freakboy3742
commented
Jul 10, 2024
freakboy3742 commented
Contributor
@neonene Thanks for the backport (and nice work hunting down the fix without access to the buildbot!)
neonene
deleted the
datetime-capitest
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment