◐ Shell
clean mode source ↗

[3.13] gh-117398: Use the correct module loader for iOS in datetime CAPI test (GH-120477) by neonene · Pull Request #121561 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

freakboy3742

merged 1 commit into

python:3.13from

neonene:datetime-capitest

Jul 10, 2024

Conversation

@neonene

@neonene neonene commented

Jul 10, 2024

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Contributor

#119604 added a CAPI test for subinterpreters in the datetime tests; however, the test uses the ExtensionFileLoader to load _testcapi. iOS requires the use of the AppleFrameworkLoader.

(backported from commit 5c58e72, AKA gh-120477)

@neonene

This comment was marked as off-topic.

@bedevere-bot

Copy link Copy Markdown

You don't have write permissions to trigger a build

@neonene

neonene commented

Jul 10, 2024

Copy link Copy Markdown

Contributor Author

@freakboy3742 Could you review the backport? I failed to trigger the iOS build bot.

freakboy3742 reacted with thumbs up emoji

@freakboy3742

Copy link Copy Markdown

Contributor

!buildbot iOS

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 987dd52 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742 freakboy3742 merged commit c08a302 into python:3.13

Jul 10, 2024

@freakboy3742

Copy link Copy Markdown

Contributor

@neonene Thanks for the backport (and nice work hunting down the fix without access to the buildbot!)

neonene reacted with heart emoji

@neonene neonene deleted the datetime-capitest branch

July 10, 2024 23:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neonene @bedevere-bot @freakboy3742