CI: Fix using `check_source` flags as bool by webknjaz · Pull Request #121848 · python/cpython
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
hugovk
changed the title
🧪🚑 Fix using
CI: Fix using check_source flags as boolcheck_source flags as bool
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit a0b205b) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
webknjaz added a commit to webknjaz/cpython that referenced this pull request
(cherry picked from commit a0b205b) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
hugovk pushed a commit that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters