GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling by markshannon · Pull Request #122158 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Conversation
Member
Computes the "peek" offset on demand, rather than attempting to keep it up to date as the stack is modified.
This is simpler and less error prone.
I'll like to backport this to 3.13, so that the fix for #122029 can be more easily backported.
iritkatriel
approved these changes
iritkatriel
commented
Jul 23, 2024
iritkatriel commented
Member
There's a mypy error, but otherwise LGTM.
624bda7
into
python:main
miss-islington-app
Bot
commented
Jul 23, 2024
miss-islington-app Bot commented
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
miss-islington-app
Bot
commented
Jul 23, 2024
miss-islington-app Bot commented
Sorry, @markshannon, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 624bda76386efd8eecf73c4ad06f997b9b25f07f 3.13
markshannon added a commit to faster-cpython/cpython that referenced this pull request
…et for error handling (pythonGH-122158)
bedevere-app
Bot
commented
Jul 23, 2024
bedevere-app Bot commented
GH-122174 is a backport of this pull request to the 3.13 branch.
nohlson pushed a commit to nohlson/cpython that referenced this pull request
…et for error handling (pythonGH-122158)
nohlson pushed a commit to nohlson/cpython that referenced this pull request
…et for error handling (pythonGH-122158)
markshannon added a commit that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
