gh-119180: Improvements to ForwardRef.evaluate by JelleZijlstra · Pull Request #122210 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
Noticed some issues while writing documentation for this method.
| return value | ||
| if owner is None: | ||
| owner = self.__owner__ | ||
| if type_params is None and owner is None: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check felt unnecessarily strict; many ForwardRefs can be evaluated correctly without worrying about type params.
blhsing pushed a commit to blhsing/cpython that referenced this pull request
Noticed some issues while writing documentation for this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels
1 participant
