◐ Shell
clean mode source ↗

gh-117139: Fix an incorrect borrow in bytecodes.c by colesbury · Pull Request #122318 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented

Jul 26, 2024

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Contributor

_PyDict_SetItem_Take2 steals both the key (i.e., sub) and the value.

`_PyDict_SetItem_Take2` steals both the key (i.e., `sub`) and the value.

@kumaraditya303 kumaraditya303 left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 674a50e into python:main

Aug 7, 2024

@colesbury colesbury deleted the gh-117139-fix-steal branch

August 7, 2024 14:45

blhsing pushed a commit to blhsing/cpython that referenced this pull request

Aug 22, 2024
`_PyDict_SetItem_Take2` steals both the key (i.e., `sub`) and the value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @markshannon @kumaraditya303