gh-122681: remove m_atan2()/c_atan2() helpers by skirpichev · Pull Request #122715 · python/cpython
This comment was marked as outdated.
This comment was marked as outdated.
Can you rebase/merge your branch to avoid the merge conflict? Then I can run buildbots on this PR.
This comment was marked as outdated.
This comment was marked as outdated.
No failures, related to this pr.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@skirpichev: Did you just create to see if removing the wrapper would work or not, or do you propose to remove it?
Yeah, I think we can remove it; testing with buildbots - for additional safety. But it's not urgent and I would appreciate @mdickinson blessing.
Current workarounds fix only few functions in cmath. Missing bugreports - another indication, that underlying problems were fixed on affected systems.
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 11a6f3d 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
