◐ Shell
clean mode source ↗

gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON by mhsmith · Pull Request #122764 · python/cpython

mhsmith

@mhsmith

@mhsmith mhsmith commented

Aug 6, 2024

•

edited by bedevere-app Bot

Loading

This was referenced

Aug 6, 2024

rgommers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @mhsmith, much appreciated.

I did do a quick check - this rename is complete, no `MODULE_LDFLAGS left except for the news snippet added here.

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mhsmith

@erlend-aasland: Thanks; are you able to merge this? There will also be a 3.13 backport.

@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 8, 2024 
…ON (pythonGH-122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
(cherry picked from commit 2f5c3b0)

Co-authored-by: Malcolm Smith <smith@chaquo.com>

@bedevere-app

gpshead pushed a commit that referenced this pull request

Aug 9, 2024

blhsing pushed a commit to blhsing/cpython that referenced this pull request

Aug 22, 2024

@lazka

Could it be that pkg-config is not used on Android? After this the .pc file contains this under cygwin:

Libs: -L${libdir} $(BLDLIBRARY)

which is not valid syntax. I'd assume it is broken under Android too.

edit: (or maybe it was the previous change this tried to fix?)

@lazka

yes, also broken for Android, I've filed #138800