◐ Shell
clean mode source ↗

gh-117139: Fix a few `_PyStackRef` related bugs by colesbury · Pull Request #122831 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented

Aug 8, 2024

edited by bedevere-app Bot

Loading

BUILD_SET should use a borrow instead of a steal. The cleanup in
_DO_CALL CONVERSION_FAILED was incorrect.

Co-authored-by: Ken Jin <kenjin@python.org>

@colesbury

@colesbury colesbury marked this pull request as ready for review

August 8, 2024 17:48

DinoV

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

blhsing pushed a commit to blhsing/cpython that referenced this pull request

Aug 22, 2024
`BUILD_SET` should use a borrow instead of a steal. The cleanup in `_DO_CALL`
`CONVERSION_FAILED` was incorrect.

Co-authored-by: Ken Jin <kenjin@python.org>

Labels

2 participants

@colesbury @DinoV