◐ Shell
clean mode source ↗

gh-120754: Add a strace helper and test set of syscalls for open().read(), Take 2 by cmaloney · Pull Request #123413 · python/cpython

added 2 commits

August 27, 2024 17:38
NOTE: This needs a full buildbot test pass before merge, see: python#121143 (comment).

1. Added `statx` to set of allowed syscall forms (Should make Raspian bot pass).
2. Check that the `fd` returned from `open` is passed to all future calls. This helps ensure things like the `stat` call uses the file descriptor rather than the `filename` to avoid TOCTOU isuses.
3. Update the `Path().read_bytes()` test case to additionally validate the reduction in`isatty`/`ioctl` + `seek` calls from python#122111
4. Better diagnostic assertion messagess from @gpshead, so when the test fails have first information immediately available. Makes remote CI debugging much simpler.

@cmaloney

@cmaloney

@cmaloney

cmaloney

@cmaloney

hauntsaninja

@cmaloney cmaloney deleted the cmaloney/strace_take_2 branch

November 3, 2024 03:40

picnixz pushed a commit to picnixz/cpython that referenced this pull request

Dec 8, 2024

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request

Jan 12, 2025