bpo-33608: Fix PyEval_InitThreads() warning by vstinner · Pull Request #12346 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Merged
Conversation
Member
The function has no return value.
Fix the following warning on Windows:
python\ceval.c(180): warning C4098: 'PyEval_InitThreads':
'void' function returning a value
The function has no return value.
Fix the following warning on Windows:
python\ceval.c(180): warning C4098: 'PyEval_InitThreads':
'void' function returning a value
bedevere-bot
added
the
awaiting merge
label
the-knights-who-say-ni
added
the
CLA signed
label
ericsnowcurrently
approved these changes
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, @vstinner! LGTM
vstinner
added
the
skip news
label
vstinner
merged commit
e3f4070
into
python:master
vstinner
deleted the
fix_ceval_warn
branch
bedevere-bot
removed
the
awaiting merge
label
vstinner
commented
Mar 15, 2019
vstinner commented
Member Author
Thanks for doing this, @vstinner! LGTM
You're welcome. I noticed this warning while looking at AppVeyor/VSTS on my unrelated PR for https://bugs.python.org/issue36301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment