◐ Shell
clean mode source ↗

bpo-33608: Fix PyEval_InitThreads() warning by vstinner · Pull Request #12346 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

python:masterfrom

vstinner:fix_ceval_warn

Mar 15, 2019

Merged

bpo-33608: Fix PyEval_InitThreads() warning#12346

vstinner

merged 1 commit into

python:masterfrom

vstinner:fix_ceval_warn

Conversation

@vstinner

@vstinner vstinner commented

Mar 15, 2019

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

The function has no return value.

Fix the following warning on Windows:

python\ceval.c(180): warning C4098: 'PyEval_InitThreads':
'void' function returning a value

https://bugs.python.org/issue33608

The function has no return value.

Fix the following warning on Windows:

    python\ceval.c(180): warning C4098: 'PyEval_InitThreads':
    'void' function returning a value

@ericsnowcurrently ericsnowcurrently left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @vstinner! LGTM

@vstinner vstinner merged commit e3f4070 into python:master

Mar 15, 2019

@vstinner vstinner deleted the fix_ceval_warn branch

March 15, 2019 15:04

@vstinner

Copy link Copy Markdown

Member Author

Thanks for doing this, @vstinner! LGTM

You're welcome. I noticed this warning while looking at AppVeyor/VSTS on my unrelated PR for https://bugs.python.org/issue36301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot