◐ Shell
clean mode source ↗

gh-123923: Defer refcounting for `f_executable` in `_PyInterpreterFrame` by colesbury · Pull Request #123924 · python/cpython

colesbury

@colesbury

@colesbury colesbury commented

Sep 10, 2024

•

edited by bedevere-app Bot

Loading 

…terFrame`

Use a `_PyStackRef` and defer the reference to `f_executable` when
possible. This avoids some reference count contention in the common case
of executing the same code object from multiple threads concurrently in
the free-threaded build.

graingert

Fidget-Spinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you've run this with refleak tests? When I attempted this, there were a ton of refleaks.

Also one question. The rest looks good to me!

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9e7691a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

Fidget-Spinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense now. Just one comment.