◐ Shell
clean mode source ↗

bpo-36356: Fix leak when updating search path in config by btharper · Pull Request #12444 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@btharper

@btharper btharper commented

Mar 19, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@btharper

btharper commented

Mar 19, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor Author

Can someone add a the skip news label for this? This is a further part of bpo-36356 and previously mentioned in Misc/NEWS.d/next/Build/2019-03-18-23-49-15.bpo-36356.WNrwYI.rst

@vstinner

Copy link Copy Markdown

Member

Your PR fix maybe the memory leak, but your PR makes me realize that it's a bug. I wrote PR #12454 to fix the bug (and a few other similar bugs). My PR also fix the memory leak.

@vstinner vstinner closed this

Mar 20, 2019

@btharper btharper deleted the env_free branch

March 20, 2019 01:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@btharper @vstinner @the-knights-who-say-ni @bedevere-bot