bpo-15718: Document the upper bound constrain on __len__ return value. by serhiy-storchaka · Pull Request #1256 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit point, other LGTM
| In CPython, the length is required to be at most :attr:`sys.maxsize`. | ||
| If the length is larger than ``sys.maxsize`` some features (such as | ||
| :func:`len`) may raise :exc:`OverflowError`. To prevent raising | ||
| ``OverflowError`` by truth value testing an object must define a |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit point, add a comma after truth value testing
by truth value testing, an object must ...
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lulouie!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With comma
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request