◐ Shell
clean mode source ↗

GH-125868: Fix STORE_ATTR_WITH_HINT specialization by markshannon · Pull Request #125876 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@markshannon

@markshannon markshannon commented

Oct 23, 2024

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

Simple fix, but challenging to test.

Also fixes a minor bug I found in dis.dis(show_caches=True) while investigating the issue.

@hroncok

hroncok commented

Oct 23, 2024

Copy link Copy Markdown

Contributor

This fixes cython/cython#6426

@hroncok hroncok left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions in NEWS are off by one.

Co-authored-by: Miro Hrončok <miro@hroncok.cz>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

+1 more reviewer

@hroncok hroncok hroncok requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon @hroncok @iritkatriel