gh-125206: Correct detection of complex numbers support in libffi by skirpichev · Pull Request #126104 · python/cpython
!buildbot SPARCv9 Oracle Solaris 11.4
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 66c1cf7 🤖
The command will test the builders whose names match following regular expression: SPARCv9 Oracle Solaris 11.4
The builders matched are:
SPARCv9 Oracle Solaris 11.4 PR
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
!buildbot PPC64LE CentOS9 LTO + PGO
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 66c1cf7 🤖
The command will test the builders whose names match following regular expression: PPC64LE CentOS9 LTO \+ PGO
The builders matched are:
PPC64LE CentOS9 LTO + PGO PR
PPC64LE build works as expected (no support)
!buildbot SPARCv9 Oracle Solaris 11.4
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit fc4ebff 🤖
The command will test the builders whose names match following regular expression: SPARCv9 Oracle Solaris 11.4
The builders matched are:
SPARCv9 Oracle Solaris 11.4 PR
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect something new, as on his local system patch was working: #125322 (comment) (test code was unchanged)
@efimov-mikhail: Can you test the fix on Debian 10?
Yes, I can. It looks like the correct fix, but it's better to test again.
This fix works fine on Debian 10.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (if the Sparc failure is unrelated).
Merged, thanks.
LGTM (if the Sparc failure is unrelated).
There are tons of unrelated errors/test failures on Solaris.
On SPARCv9 only configure test was checked. It reports "yes" (supported). But it seems that ctypes tests weren't run. Sadly that configure script doesn't report library versions (even if this is available e.g. with pkg-config --modversion <lib>.
On SPARCv9 only configure test was checked. It reports "yes" (supported). But it seems that ctypes tests weren't run. Sadly that configure script doesn't report library versions (even if this is available e.g. with
pkg-config --modversion <lib>.
We could fix that if we wanted.
We could fix that if we wanted.
If that does make sense, I can open an issue. But I admit, that I don't know how to solve this in general: maybe every snowflake^Wlibrary will require a special treatment.
BTW, version information is unavailable in the config.log (even for versioned checks like for libmpdec).
IIRC (from the top of my head), the pkg-config macro will print version information if you specify version bounds (see the sqlite3 third-party detection code in configure.ac). My gut feeling for implementing such a thing would be to create a wrapper for PKG_CHECK_MODULES and ensure that we print version info in the action-if-found block. I'm not sure if it is worth it, but it would be convenient for debugging third-party dependency detection.
the pkg-config macro will print version information if you specify version bounds (see the sqlite3 third-party detection code in configure.ac).
Quick test for mpdec (which uses same PKG_CHECK_MODULES macro for system libmpdec, just as for sqlite3) shows, that it's not true:
$ ./configure 2>&1|grep mpdec
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... yes
