◐ Shell
clean mode source ↗

gh-126220: Fix crash on calls to `_lsprof.Profiler` methods with 0 args (backportable) by sobolevn · Pull Request #126271 · python/cpython

sobolevn

@sobolevn

@sobolevn sobolevn commented

Nov 1, 2024

•

edited by bedevere-app Bot

Loading

@picnixz picnixz changed the title gh-126220: Fix crash on calls to _lsprof.Profiler methods with 0 args gh-126220: Fix crash on calls to _lsprof.Profiler methods with 0 args (backportable)

Nov 1, 2024

@picnixz

I'm changing the title of the PR just so that we don't have two PRs that look exactly the same on the issue.

erlend-aasland

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(BTW, PyErr_Format always returns NULL)

 
…JAJCU.rst

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 1, 2024 
…h 0 args (backportable) (pythonGH-126271)

(cherry picked from commit 28b148f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 1, 2024 
…h 0 args (backportable) (pythonGH-126271)

(cherry picked from commit 28b148f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

@bedevere-app

@bedevere-app

@sobolevn

Thank you! I will backport this change and go back to the original PR soon :)

@erlend-aasland

I'm changing the title of the PR just so that we don't have two PRs that look exactly the same on the issue.

Next time, remember to edit such a change out of the squashed commit title ;)

@erlend-aasland

Nit: ideally, the other PR would have received the title change (adapt to Argument Clinic ...), not this one.

sobolevn added a commit that referenced this pull request

Nov 1, 2024 
…th 0 args (backportable) (GH-126271) (#126311)

gh-126220: Fix crash on calls to `_lsprof.Profiler` methods with 0 args (backportable) (GH-126271)
(cherry picked from commit 28b148f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

sobolevn added a commit that referenced this pull request

Nov 1, 2024 
…th 0 args (backportable) (GH-126271) (#126310)

gh-126220: Fix crash on calls to `_lsprof.Profiler` methods with 0 args (backportable) (GH-126271)
(cherry picked from commit 28b148f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

picnixz pushed a commit to picnixz/cpython that referenced this pull request

Dec 8, 2024 
…h 0 args (backportable) (python#126271)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request

Jan 12, 2025 
…h 0 args (backportable) (python#126271)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>