◐ Shell
clean mode source ↗

bpo-36050: optimize HTTPResponse.read() by methane · Pull Request #12698 · python/cpython

methane

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

@methane methane commented

Apr 5, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

  • No need to split read
  • No need to partial read caused by EINTR

https://bugs.python.org/issue36050

 
* No need to chunking for now.
* No need to partial read caused by EINTR for now.

@vadmium

vadmium commented

Apr 6, 2019

Copy link Copy Markdown

Member

This looks good to me, Inada.

@methane methane merged commit d6bf6f2 into python:master

Apr 6, 2019

@methane methane deleted the bpo36050-httpclient branch

April 11, 2019 08:28

@admackin

Copy link Copy Markdown

FYI: this change has caused a regression in HTTP response under SSL resulting in inability to read files > 2 GiB over SSL: https://bugs.python.org/issue42853 .

Is there some reason we can't move back to eg 1GB chunks in MAXAMOUNT as a sane middle ground instead of 1MiB (old) or infinite (new)?
jthetzel reacted with thumbs up emoji

methane added a commit to methane/cpython that referenced this pull request

Jul 28, 2021

ambv pushed a commit that referenced this pull request

Jul 28, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance

Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@methane @vadmium @admackin @the-knights-who-say-ni @bedevere-bot